Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Upgrade axios version to ^1.7.2 #4680

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Jun 18, 2024

Fixes #4655

Description

This PR updates the axios package version from 0.28.0 to ^1.7.2 and modifies the browserify settings to work with pure ESM packages, using babelify to transform ES module syntax to CommonJS and esmify to be able to read them with browserify.

Specific Changes

  • Update axios 0.28.0 to ^1.7.2.
  • Added esmify ^2.1.1 and babelify ^10.0.0 to botframework-connector.
  • Added babel configuration to botframework-connector.

Testing

The following image shows the botframework-connector unit tests working after the update.
image

@JhontSouth JhontSouth requested a review from a team as a code owner June 18, 2024 16:19
@tracyboehrer tracyboehrer merged commit 066b405 into main Jun 18, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/axios branch June 18, 2024 16:32
@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9568619560

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.431%

Totals Coverage Status
Change from base Build 9370526503: 0.0%
Covered Lines: 20425
Relevant Lines: 22900

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update axios in botbuilder-core from 0.28 to 1.6.4
3 participants