Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] use new HttpContent each time for HttpRequestMock #1277

Closed
tomlm opened this issue Jul 24, 2020 · 0 comments
Closed

[PORT] use new HttpContent each time for HttpRequestMock #1277

tomlm opened this issue Jul 24, 2020 · 0 comments
Labels
changes required Reviews has requested changes to be made before approval

Comments

@tomlm
Copy link
Contributor

tomlm commented Jul 24, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4199

Description

use new HttpContent each time: when used by some custom action, they may dispose it so we can't reuse HttpContent

Specific Changes

add HttpResponseMockContent to generate HttpContent

Testing

update TestScriptTests_HttpRequestMock.test.dialog for repeating bytearray response

Changed projects

  • Microsoft.Bot.Builder.Dialogs.Adaptive.Testing
  • Microsoft.Bot.Builder.Dialogs.Adaptive.Tests

[Adaptive,changes required]
@github-actions github-actions bot added Adaptive changes required Reviews has requested changes to be made before approval labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changes required Reviews has requested changes to be made before approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tracyboehrer @tomlm