use new HttpContent each time for HttpRequestMock #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieofxie
changed the title
cleemullins
suggested changes
Jul 1, 2020
...s/Microsoft.Bot.Builder.Dialogs.Adaptive.Testing/HttpRequestMocks/HttpResponseMockContent.cs
Outdated
Show resolved
Hide resolved
...s/Microsoft.Bot.Builder.Dialogs.Adaptive.Testing/HttpRequestMocks/HttpResponseMockContent.cs
Show resolved
Hide resolved
...s/Microsoft.Bot.Builder.Dialogs.Adaptive.Testing/HttpRequestMocks/HttpResponseMockContent.cs
Show resolved
Hide resolved
...s/Microsoft.Bot.Builder.Dialogs.Adaptive.Testing/HttpRequestMocks/SequenceResponseManager.cs
Outdated
Show resolved
Hide resolved
tomlm
reviewed
Jul 3, 2020
...s/Microsoft.Bot.Builder.Dialogs.Adaptive.Testing/HttpRequestMocks/SequenceResponseManager.cs
Show resolved
Hide resolved
mrivera-ms
added
the
changes required
|
@xieofxie, please fix the conflicts so we can move forward with reviewing and merging. |
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive.Testing/HttpRequestMocks/SequenceResponseManager.cs
|
@mrivera-ms Thanks! Updated. |
This was referenced Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use new HttpContent each time: when used by some custom action, they may dispose it so we can't reuse HttpContent
Specific Changes
add HttpResponseMockContent to generate HttpContent
Testing
update TestScriptTests_HttpRequestMock.test.dialog for repeating bytearray response