Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing super() call to self on members added/removed in TAH #1675

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Changing super() call to self on members added/removed in TAH #1675

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16b73f9
Changing super() call to self on members added/removed in TeamsActivi…
axelsrz May 13, 2021
4fe2e7c
Merge branch 'main' into axsuarez/easy-override-members-added-tah
tracyboehrer Jun 15, 2021
0c3ccc5
Merge branch 'main' into axsuarez/easy-override-members-added-tah
tracyboehrer Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py
View file
Open in desktop
Expand Up @@ -777,9 +777,7 @@ async def on_teams_members_added( # pylint: disable=unused-argument
ChannelAccount().deserialize(member.serialize())
for member in teams_members_added
]
return await super().on_members_added_activity(
teams_members_added, turn_context
)
return await self.on_members_added_activity(teams_members_added, turn_context)

async def on_teams_members_removed_dispatch( # pylint: disable=unused-argument
self,
Expand Down Expand Up @@ -833,7 +831,7 @@ async def on_teams_members_removed( # pylint: disable=unused-argument
ChannelAccount().deserialize(member.serialize())
for member in teams_members_removed
]
return await super().on_members_removed_activity(members_removed, turn_context)
return await self.on_members_removed_activity(members_removed, turn_context)

async def on_teams_channel_deleted( # pylint: disable=unused-argument
self, channel_info: ChannelInfo, team_info: TeamInfo, turn_context: TurnContext
Expand Down