Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1683] Fix is_skill_claim validation for anonymous authentication #1684

Merged

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #1683

Description

This PR fixes the order of the validations in the is_skill_claim method to allow using anonymous authentication.

Specific Changes

  • Updated skill_validation class to invert the order of the conditions that validate the VERSION_CLAIM and the ANONYMOUS_SKILL_APP_ID to keep consistency with .NET and JS SDKs.
  • Fixed bug in list initialization in test_auth.

Testing

This image shows a bot with anonymous authentication working.
image

And this image shows the test passing in the CI pipeline after the changes.
image

@axelsrz axelsrz merged commit 2bd4d42 into microsoft:main Jun 3, 2021
@santgr11 santgr11 deleted the southworks/fix/anonymous-claim-validation branch July 22, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_skill_claim validation is not working for Anonymous authentication
2 participants