This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#124
Proposed Changes
There are two issues:
sample code used from NPM package page throws error of Fetch not found. Sticking it in the global, as it is currently done is not working for the NPM package usage. This fix adds the dependency to the top of serviceBase.js.
Calling via npm package instead of cli, there is no way to pass in LUIS config values because the API begins at /api/lib and the params passed into a method are not overriding the serviceBase.config values. This fix allows the method call with params to fix that. I could see an argument for beginning the package at /api instead but the config settings at the top of serviceBase is not clear what the code is attempting to do.
correct example call:
Testing
You don't have any npm-package based tests so I didn't want to assume anything here. I'm happy to write mocha tests though.
Docs
The docs for the NPM package are light. I would love to be able to use this package when I write the
samples for the LUIS docs. If you would like some help with these docs, let me know.