Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default LUIS application information for API call to LU library #255

Closed
vishwacsena opened this issue Oct 21, 2019 · 3 comments
Closed
Labels
R8 Release 8 - March 16th, 2020

Comments

@vishwacsena
Copy link
Contributor

API call to LU library to parse lu to luis does not include any default values for application information (name, description, locale). Consider adding default values for API route so callers do not always have to set these before calling LUIS.

The current work around is for users to set these via application description properties.

@scheyal
Copy link
Contributor

scheyal commented Oct 21, 2019

@vishwacsena - do you imagine this as default values in config file? So we'll have bf config:set -key LUAppName - value "My Luis App"
Or maybe an "init" command parallel to QnAMaker

@vishwacsena
Copy link
Contributor Author

@scheyal - this is one of those where the library .vs. CLI route both need to be handled.

For CLI route, we already do support defaults as well as override via CLI arguments. We could totally do config file as well for consistency.
This issue was more for consumption of the LU parser as library where the config or CLI arguments route does not work.

Hope that helps clarify.

@munozemilio munozemilio added the R7 Release 7 - December 10th, 2019 label Oct 22, 2019
@munozemilio munozemilio added R8 Release 8 - March 16th, 2020 and removed R7 Release 7 - December 10th, 2019 labels Nov 26, 2019
@munozemilio
Copy link
Member

FIxed by #298

vishwacsena pushed a commit that referenced this issue Feb 11, 2020
* Fix

* fixing tests.

* fix default locale issue

Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Development

No branches or pull requests

3 participants