Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bf luis:version:export output error, which causes bf luis:generate:cs to fail #848

Closed
manish-95 opened this issue Jun 9, 2020 · 5 comments · Fixed by #857
Closed

bf luis:version:export output error, which causes bf luis:generate:cs to fail #848

manish-95 opened this issue Jun 9, 2020 · 5 comments · Fixed by #857
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.

Comments

@manish-95
Copy link

Versions

@microsoft/botframework-cli/4.9.1 win32-x64 node-v12.13.1

Describe the bug

The output json file generated by bf luis:version:export differs slightly from the json file downloaded from the LUIS Portal. This causes the bf luis:generate:cs command to fail with the error "Invalid LUIS JSON file content" while used with the output generated by the export command, but succeed with the .json file from LUIS portal. Screenshots attached below, showing these differences.

To Reproduce

Steps to reproduce the behavior:

  1. Export .json file using bf luis:version:export
  2. Export same .json file from luis.ai portal
  3. Run the bf luis:generate:cs command using both files as input
  4. Note the error in the case of the file generated with bf tool.

Expected behavior

The .cs Helper file must be produced irrespective of the source of the input json file.

Screenshots

image
The file on the left is generated from bf, the file on the right is downloaded from the LUIS portal. Note the differences for regex features and regex entities, which is causing the failure of the bf generate command.

@a-b-r-o-w-n a-b-r-o-w-n added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Jun 9, 2020
@vishwacsena vishwacsena assigned axelsrz and unassigned vishwacsena Jun 10, 2020
@vishwacsena
Copy link
Contributor

@axelsrz can you take a look and comment?

@manish-95
Copy link
Author

Hi @axelsrz . Any updates or timeline regarding this issue? Would be great to get a quick update, if any on this. Thank you.

@axelsrz
Copy link
Member

axelsrz commented Jun 11, 2020

@munozemilio @vishwacsena is this really a luisgen issue or a luis:version:export? I was not aware that the names of those properties were camelcase/snakecase interchangegable.

In the case this is supposed to be supported by luisgen, it's an easy fix and would be done shortly after receiving confirmation.

@vishwacsena
Copy link
Contributor

@axelsrz yes. bf-lu accomodates for casing because the exported json is different via the LUIS SDK .vs. portal. I chatted with @munozemilio about this prior to 4.9 patch release and he said he is going to make a change to remove dependency on the LUIS SDK..

@axelsrz
Copy link
Member

axelsrz commented Jun 11, 2020

@axelsrz yes. bf-lu accomodates for casing because the exported json is different via the LUIS SDK .vs. portal. I chatted with @munozemilio about this prior to 4.9 patch release and he said he is going to make a change to remove dependency on the LUIS SDK..

Got it, will start working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants