Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix exit code not thrown issue when cli running into exception #1022

Merged
merged 7 commits into from Oct 19, 2020
Merged

fix exit code not thrown issue when cli running into exception #1022

merged 7 commits into from Oct 19, 2020

Conversation

feich-ms
Copy link
Contributor

fix #1005

@feich-ms
Copy link
Contributor Author

@munozemilio hi, this is resolving a bug raised by Tom #1005, the fix is just one line code 'this.exit(1)' in command.ts, all the other changes are unit tests adjustments. please let me know if you have any concerns about these changes.

@feich-ms feich-ms merged commit 091464d into main Oct 19, 2020
@feich-ms feich-ms deleted the feich/fixExitCode branch October 19, 2020 02:15
@feich-ms feich-ms mentioned this pull request Oct 19, 2020
Closed
@feich-ms feich-ms mentioned this pull request Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@munozemilio munozemilio Awaiting requested review from munozemilio

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bf command line tools silently fail
2 participants
@feich-ms @boydc2014