Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick changes from main #1194

Closed
wants to merge 18 commits into from
Closed

cherry pick changes from main #1194

wants to merge 18 commits into from

Conversation

tsuwandy
Copy link
Contributor

Fixes #1193

  1. Support composer client using proxy
  2. Fixed bug in bf orchestrator:add

munozemilio and others added 17 commits April 1, 2021 17:42
@munozemilio
Bumping version for next release (#1174)
7e5fa93
@hcyang
Fix for issue 1177 (#1178)
74baacc
@tsuwandy
Update add.ts
2648f2c
@feich-ms
Replace node fetch to axios to enable proxy in luis and qnamaker build (
6745788 
#1182)

* replace node fetch and luis client to axios to enable proxy in luis and qnamaker build

* fix tests
@chrimc62
Fixes #1184 (#1185)
393d33d 
Treats files with identical content as not being duplicated.  This is because
nuget likes to copy the same files in multiple places.

Co-authored-by: Chris McConnell <chrimc>
@feich-ms
fix axios bug to support https proxy (#1186)
1a5070e
@tsuwandy
Merge branch 'main' into tiens-patch-1
6a14e1e
@tsuwandy
node-fetch-with-proxy changes
1758a7c
@tsuwandy
node-fetch -> node-fetch-with-proxy
33dac07
@chrimc62 @cosmicshuai
Switch to axios to support proxy server when merging. (#1190)
161c029 
* Switch to axios to support proxy server when merging.
Normalize sorting to reduce variation.

* modify https proxy setting

* refactor

* fix lint

* fix lint

Co-authored-by: Chris McConnell <chrimc>
Co-authored-by: cosmicshuai <shuai_uf@outlook.com>
@tsuwandy
Merge branch 'main' into tiens-patch-1
92c6186
@cosmicshuai
fix lint
4a13a96
@tsuwandy
fix for orchestrator:add -t luis/qna
6ae3ee2
@tsuwandy
Merge branch 'tiens-patch-1' into 4.13
bbe9e29
@tsuwandy
Revert "Merge branch 'tiens-patch-1' into 4.13"
0b33dd5 
This reverts commit bbe9e29, reversing
changes made to bf75952.
@tsuwandy
cherry pick changes from main
805ce88
@tsuwandy
Update pnpm-lock.yaml
9a4e061
@daveta
Copy link
Contributor

daveta commented Apr 15, 2021

Getting chatdown build errors.. @feich-ms does this look familiar?
src/commands/chatdown/convert.ts(159,75): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?

@feich-ms
Copy link
Contributor

feich-ms commented Apr 15, 2021 •
edited
Loading

Getting chatdown build errors.. @feich-ms does this look familiar?
src/commands/chatdown/convert.ts(159,75): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?

I ever ran into this when I rush build locally, but haven't seen this in online CI validation. I can repro this error after I run rush update and then rush build. I think this may be caused by the upgrade of typescript version, fix should be easy https://stackoverflow.com/questions/65354965/error-ts2794-expected-1-arguments-but-got-0-did-you-forget-to-include-void

@daveta
Copy link
Contributor

daveta commented Apr 15, 2021

This is referencing a package with security problems.

@daveta daveta closed this Apr 15, 2021
@tsuwandy tsuwandy deleted the tiens-4.13 branch April 15, 2021 16:50
This was referenced Dec 31, 2021
Open
Open
Open
Open
This was referenced Aug 19, 2022
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 20, 2022
Open
This was referenced Jun 21, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 30, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins Awaiting requested review from cleemullins

@joshgummersall joshgummersall Awaiting requested review from joshgummersall

@munozemilio munozemilio Awaiting requested review from munozemilio munozemilio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tsuwandy @daveta @feich-ms @munozemilio @hcyang @chrimc62 @cosmicshuai