-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix import filtered intents not work in luis:cross-train #1232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment on code optimization
|
||
const matchedUtterence = luObj.utterances.find(e => e.intent === intent) | ||
const fileContent = `# ${intent}\r\n${parseUtterancesToLu([matchedUtterence], luObj)}` | ||
let cloned = {...(isAbsolutePath ? importFile : filePathOrFound[0])} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const
, also does this need to be a deep clone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I used a deep clone here is due to I don't want to change the original content of luis and qna files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a deep clone actually, that was my question. See Typescript playground for explanataion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I just fixed this.
closes: #1210
In this PR, for the test cases of using imported intents User report case will only includes the referenced intents in the generated files.
Here is the new result of Cross-train for that case above: