syncLabelResolverEx should return after addBatch #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return after addBatch
munozemilio
reviewed
Jul 7, 2021
| @@ -161,6 +161,7 @@ export class OrchestratorBuild { | |||
| Utility.debuggingLog('OrchestratorBuild.syncLabelResolverEx(), ready to call LabelResolver.addBatch()'); | |||
| LabelResolver.addBatch(target); | |||
| Utility.debuggingLog('OrchestratorBuild.syncLabelResolverEx(), after calling LabelResolver.addBatch()'); | |||
| return; | |||
There was a problem hiding this comment.
Should we add a test to catch this scenario?
daveta
approved these changes
Jul 7, 2021
hcyang
approved these changes
Jul 7, 2021
munozemilio
requested changes
Jul 7, 2021
munozemilio
approved these changes
Jul 8, 2021
tsuwandy
added a commit
that referenced
this pull request
Jul 8, 2021
* Update build.ts Return after addBatch * Update create.test.ts
tsuwandy
added a commit
that referenced
this pull request
Jul 8, 2021
* Update build.ts Return after addBatch * Update create.test.ts
munozemilio
pushed a commit
that referenced
this pull request
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1262