support section and cross-train in bf lu #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/botframework-cli into feich/AddSectionSupport
munozemilio
reviewed
Nov 26, 2019
munozemilio
reviewed
Nov 26, 2019
munozemilio
reviewed
Nov 26, 2019
munozemilio
reviewed
Nov 26, 2019
munozemilio
reviewed
Nov 26, 2019
munozemilio
reviewed
Nov 26, 2019
munozemilio
reviewed
Nov 26, 2019
There was a problem hiding this comment.
Few nit's. I would like @vishwac to give the last glance since he is more familiar with the spec
|
@munozemilio thanks for all the constructive comments. I have resoved all of them. And I also removed all the cli related changes and keep pure cross train api only. @vishwacsena Pls help to verify and approve if there are no other issues. Thanks. |
vishwacsena
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge section CRUD and cross-train functionalities into master