Adding luis:application:import cmd #367
Conversation
|
packages/command/src/index.ts
Outdated
| @@ -5,5 +5,6 @@ | |||
|
|
|||
| import {CLIError, Command, flags} from './command' | |||
| import utils from './utils' | |||
| export {CLIError, Command, flags, utils} | |||
| import ReadPipedStdin from './readpipeddata' | |||
There was a problem hiding this comment.
This is no needed, we are exposing this functionality as part of the command class. Please refer to luis:convert to see an example.
There was a problem hiding this comment.
refactored. after looking at it though, i still think it should live in utils because we have all other read / write / parse functionality there, so now there is this one-off. maybe there's a deeper inconsistency with how we achieve code reuse - through class inheritance vs utility functions. maybe we should have done it all one way or another. anyways...this works for now.
…osoft/botframework-cli into 306-luis-application-import
packages/luis/src/utils/index.ts
Outdated
| @@ -18,6 +18,20 @@ const filterConfig = (config: any, prefix: string) => { | |||
| }, {}) | |||
| } | |||
|
|
|||
| const getInputFromFileOrStdin = async (args: any): Promise<string> => { | |||
There was a problem hiding this comment.
I dont think we have to do this here
| @@ -55,6 +69,10 @@ const processInputs = async (flags: any, flagLabels: string[], configDir: string | |||
| flagLabels | |||
| .filter(flag => flag !== 'help') | |||
| .map((flag: string) => { | |||
| if (flag === 'in') { | |||
There was a problem hiding this comment.
Should we exclude this flag?
There was a problem hiding this comment.
meaning remove it from input processing in utils? i don't think so - i think we should stay consistent
| } | ||
|
|
||
| async getImportJSON(input: string) { | ||
| if (input) { |
There was a problem hiding this comment.
Stdin should override flags.in
There was a problem hiding this comment.
If no stdin or flags.in value passed, CLIError should be thrown asking the user to provide input
…osoft/botframework-cli into 306-luis-application-import
|
fixes #367 |
|
Hi! When this changes will be available on npm? |
No description provided.