Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to BF-LU to exclude empty descriptors on intents (from JSON -> LU) #383

Merged
merged 8 commits into from Nov 27, 2019

Conversation

vishwacsena
Copy link
Contributor

Fixing a bug where BF-LU library was incorrectly writing out a @ intent intentName even when the intent has an empty list of descriptors (usesFeature)

@@ -0,0 +1,32 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are adding all launch configs at the root

Copy link
Member

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the launch.json before merge

@vishwacsena vishwacsena merged commit d669410 into master Nov 27, 2019
@vishwacsena vishwacsena deleted the vishwac/feature-intent-fix branch November 27, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants