bf-lu perf updates #554
Merged
bf-lu perf updates #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 6, 2020 10:21
…into vishwac/472 m master
feich-ms
reviewed
Feb 10, 2020
feich-ms
approved these changes
Feb 10, 2020
munozemilio
reviewed
Feb 11, 2020
munozemilio
reviewed
Feb 11, 2020
|
@munozemilio updated. I also noticed that separating the qna from qna alterations causes all files to parsed twice which is expensive. We should probably have qnabuilder do both qnaList as well as qnaAlterations with a single parse. |
munozemilio
reviewed
Feb 11, 2020
munozemilio
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made bunch of fixes to improve perf for core bf-lu operations.
Notable example include large .lu files - e.g. email skill.lu
This multi-file convert now takes ~1,715ms .vs. 5,704ms, better by about 70%
The BF-LU tests now take ~89s .vs. ~129s, better by about 30%.