Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bf-lu: update some function to support load file content directly #626

Merged
merged 19 commits into from Mar 5, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Mar 3, 2020

Changes in this PR:

  1. Optimize the interface of crossTrainer.crossTrain function to remove the dependency on LuObject and LuOptions class
  2. Optimize cross-train.train function to make it accept both config path and config content which is useful for auto-detecting config in cross train CLI package
  3. Add some help functions in fileHelper.ts to help above chatdown plugin and bf cli #1 and Adding Unit Test to Chatdown #2
  4. adjust test cases to test non file path id

@feich-ms
Copy link
Contributor

feich-ms commented Mar 5, 2020

@munozemilio, this PR is refactoring some function interfaces of crossTrainer based on composer feedbacks. Please let me know if you have any concerns.

@feich-ms feich-ms merged commit 475cc3d into master Mar 5, 2020
@feich-ms feich-ms deleted the leilzh/test branch March 16, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants