Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lu build bug when training empty intents #643

Merged
merged 2 commits into from Mar 9, 2020
Merged

Conversation

feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Mar 9, 2020

Fix two bugs:

  1. fix bug Unable to successfully publish to LUIS (sometimes) BotFramework-Composer#2195. Luis API will throw exception when training lu file with empty intents(with no utterances and patterns). This PR removes the empty intents before creating and training/publishing lu models. Meanwhile, it will log out a messages such as [WARN]: empty intent(s) # A, # B are filtered when handling luis application
  2. fix invalid model info error message [WARN]: Invalid model info found. Skipping "> !# @enableSections = true which was false error. enableSections is used in luParser.js. The fix here is to avoid the error message.

Copy link
Contributor

@boydc2014 boydc2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @munozemilio i'm approving and merging this, since it's a P0 bug in composer on this, and this is a very minor fix, let us know if you have any concerns.

@feich-ms feich-ms merged commit da24593 into master Mar 9, 2020
@feich-ms feich-ms deleted the feich/lubuildFix branch March 9, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants