Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lu parser to handle feature assignment via imports #926

Merged
merged 1 commit into from Aug 7, 2020

Conversation

vishwacsena
Copy link
Contributor

Fix an issue in lu parser where feature assignment via imports were not handled correctly.

phrases.lu:

@ phraseList addPhrases(interchangeable)=
- add, set

add.lu:

[phrase.lu](./phrases.lu)
@ ml add() usesFeature addPhrases

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

Codecov Report

Merging #926 into master will increase coverage by 1.25%.
The diff coverage is 79.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   55.78%   57.04%   +1.25%     
==========================================
  Files         220      220              
  Lines       16188    17029     +841     
  Branches     2320     2337      +17     
==========================================
+ Hits         9031     9714     +683     
- Misses       6587     6730     +143     
- Partials      570      585      +15     
Impacted Files Coverage Δ
packages/lu/src/parser/lu/luMerger.js 77.66% <0.00%> (-0.47%) ⬇️
packages/lu/src/parser/lubuild/builder.ts 11.78% <0.00%> (-0.05%) ⬇️
packages/lu/src/parser/qnabuild/builder.ts 19.79% <0.00%> (-0.07%) ⬇️
packages/lu/src/parser/utils/enums/CLI-errors.js 100.00% <ø> (ø)
packages/luis/src/commands/luis/convert.ts 85.71% <0.00%> (+0.29%) ⬆️
packages/lu/src/parser/lufile/parseFileContents.js 81.67% <100.00%> (+0.41%) ⬆️
packages/lu/src/parser/luis/luisValidator.js 90.24% <100.00%> (+1.50%) ⬆️
...kages/qnamaker/src/commands/qnamaker/kb/publish.ts 85.71% <0.00%> (-14.29%) ⬇️
...aker/src/commands/qnamaker/endpointkeys/refresh.ts 85.71% <0.00%> (-14.29%) ⬇️
...atics/confusion_matrix/AppBinaryConfusionMatrix.ts 85.71% <0.00%> (-14.29%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9695b25...43c5108. Read the comment docs.

@chrimc62 chrimc62 merged commit 8f27460 into master Aug 7, 2020
@munozemilio munozemilio deleted the vishwac/import-feature-fix branch February 12, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants