Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Bot Solutions nuget package - CompleteAsync is never called when single turn dialogs end #1946

Closed
hansmbakker opened this issue Jul 25, 2019 · 2 comments
Closed

Bot Solutions nuget package - CompleteAsync is never called when single turn dialogs end #1946

hansmbakker opened this issue Jul 25, 2019 · 2 comments
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. Status: In Progress This work item in underway. Type: Bug Something isn't working
Projects
Core (Templates, Libraries, and Samples)
Milestone
Vibranium 0.6 Rel...

Comments

@hansmbakker
Copy link

hansmbakker commented Jul 25, 2019 •
edited
Loading

This is a bug in Virtual Assistant that was fixed in Enterprise Bot template before. The fix is not applied in RouterDialog in the nuget package and therefore the bug exists in Virtual Assistant.

I'm opening this new issue to keep track of it. The original bug is #643 .
@hansmbakker hansmbakker added Needs Triage Needs to be triaged for assignment Type: Bug Something isn't working labels Jul 25, 2019
@Dewain27 Dewain27 added this to Backlog in Core (Templates, Libraries, and Samples) via automation Jul 25, 2019
@Dewain27 Dewain27 added Status: Backlog This will go in the product backlog and removed Needs Triage Needs to be triaged for assignment labels Jul 25, 2019
@lauren-mills lauren-mills added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Aug 15, 2019
@lauren-mills
Copy link
Contributor

Hi @hansmbakker, we've added this bug to our backlog and will let you know once we get started on it.

@lauren-mills lauren-mills added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Aug 15, 2019
@lauren-mills lauren-mills moved this from Backlog to Committed in Core (Templates, Libraries, and Samples) Aug 15, 2019
@lauren-mills lauren-mills added Status: Committed This has been confirmed for the next release. and removed Status: Backlog This will go in the product backlog labels Aug 15, 2019
@lauren-mills lauren-mills added this to the Vibranium 0.6 Release milestone Aug 15, 2019
@lauren-mills lauren-mills mentioned this issue Sep 10, 2019
Merged
1 task
@lauren-mills lauren-mills moved this from Committed to In progress in Core (Templates, Libraries, and Samples) Sep 10, 2019
@lauren-mills lauren-mills added Status: In Progress This work item in underway. and removed Status: Committed This has been confirmed for the next release. labels Sep 10, 2019
@darrenj darrenj closed this as completed Sep 11, 2019
Core (Templates, Libraries, and Samples) automation moved this from In progress to Done Sep 11, 2019
@hansmbakker
Copy link
Author

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. Status: In Progress This work item in underway. Type: Bug Something isn't working
Projects
Core (Templates, Libraries, and Samples)
  
Done
Milestone
Vibranium 0.6 Release
Development

No branches or pull requests
4 participants
@hansmbakker @Dewain27 @lauren-mills @darrenj