This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Lib] Bug fix for single-turn dialogs not triggering CompleteAsync #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-mills
requested review from
ryanisgrig
and removed request for
darrenj and
ryanisgrig
ryanisgrig
approved these changes
Sep 10, 2019
lzc850612
approved these changes
Sep 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1946
Purpose
What is the context of this pull request? Why is it being done?
Fixes a bug that caused single-turn dialogs not to trigger CompleteAsync method
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General
- [ ] I have added or updated the appropriate tests- [ ] I have updated related documentationBots
- [ ] I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience- [ ] I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese.lufiles and validated that deployment is successfulDeployment Scripts
- [ ] I have replicated my changes in the Virtual Assistant Template and Sample projects- [ ] I have replicated my changes in the Skill Template and Sample projects