Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[C#][Bot-Solutions] Avoid use of the Deprecated LuisServices class #3617

Closed
2 tasks done
Batta32 opened this issue Aug 13, 2020 · 7 comments · Fixed by #3618
Closed
2 tasks done

[C#][Bot-Solutions] Avoid use of the Deprecated LuisServices class #3617

Batta32 opened this issue Aug 13, 2020 · 7 comments · Fixed by #3618
Assignees
@Batta32
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. feature-request A request for new functionality or an enhancement to an existing one. in-progress The issue is assigned and it is being worked on. stale The issue hasn't been updated in a long time and will be automatically closed. Team: Kobuk This issue is assigned to the Kobuk team.

Comments

@Batta32
Copy link
Collaborator

Batta32 commented Aug 13, 2020 •
edited
Loading

User Story

As SDK R10 dotnet release was published
I want to avoid the "LuisService is obsolete: This class is deprecated" error doing a rehome of the dependencies of Microsoft.Bot.Configuration used in BotSettingsBase

Acceptance Criteria

List your requirements.

Resources

Notes

Provide any additional information.
BotSettingsBase.cs file with error
image
@Batta32 Batta32 added the Needs Triage Needs to be triaged for assignment label Aug 13, 2020
@Batta32 Batta32 mentioned this issue Aug 13, 2020
Merged
3 tasks
@peterinnesmsft
Copy link
Contributor

Hi @Batta32,

I did some further digging around and spoke to some folks on our team as well as in the SDK team. As I understand it, the dependencies that we have in Microsoft.Bot.Configuration that we use today (such as LuisService) are holdovers from the .bot file days, and the official recommendation from the SDK team appears to be that we should move away from depending on the SDK for these definitions in favor of customers defining their own.

Having discussed with the team, I think the right path forward for now is that we should take copies of any of the dependencies we have here on Microsoft.Bot.Configuration, and rehome them within Microsoft.Bot.Solutions. That way we can ensure we fully support this to our customers without them potentially being deprecated and removed from the SDK in the future.

Let's touch base tomorrow and we can figure out how to fit this into the backlog.

@peterinnesmsft peterinnesmsft added in-progress The issue is assigned and it is being worked on. feature-request A request for new functionality or an enhancement to an existing one. and removed Needs Triage Needs to be triaged for assignment labels Aug 17, 2020
@Batta32
Copy link
Collaborator Author

Batta32 commented Aug 18, 2020 •
edited
Loading

Sure @peterinnesmsft ! We will review the used dependencies of Microsoft.Bot.Configuration in order to rehome them within Microsoft.Bot.Solutions.

We added this task in this iteration as top prior with the end-to-end test of R10 and we can review it today 😊.

@Batta32
Copy link
Collaborator Author

Batta32 commented Aug 19, 2020

We've updated the description of this issue adding the necessary information to do the rehome of the Microsoft.Bot.Configuration dependencies to a new folder Services of Microsoft.Bot.Solutions

@peterinnesmsft peterinnesmsft added the Team: Kobuk This issue is assigned to the Kobuk team. label Aug 20, 2020
@peterinnesmsft peterinnesmsft mentioned this issue Aug 21, 2020
Closed
@peterinnesmsft peterinnesmsft linked a pull request Sep 1, 2020 that will close this issue
[C#][Bot-Solutions] Rehome used services of Microsoft.Bot.Configuration to Microsoft.Bot.Solutions in Services folder #3618
Merged
3 tasks
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The issue hasn't been updated in a long time and will be automatically closed. label Sep 20, 2020
@Batta32
Copy link
Collaborator Author

Batta32 commented Sep 21, 2020

This issue is solved with PR #3618.

@peterinnesmsft peterinnesmsft removed the stale The issue hasn't been updated in a long time and will be automatically closed. label Sep 30, 2020
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The issue hasn't been updated in a long time and will be automatically closed. label Oct 31, 2020
@peterinnesmsft peterinnesmsft removed the stale The issue hasn't been updated in a long time and will be automatically closed. label Nov 2, 2020
@CezaryMarcjan CezaryMarcjan added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Nov 6, 2020
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The issue hasn't been updated in a long time and will be automatically closed. label Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Batta32 Batta32

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. feature-request A request for new functionality or an enhancement to an existing one. in-progress The issue is assigned and it is being worked on. stale The issue hasn't been updated in a long time and will be automatically closed. Team: Kobuk This issue is assigned to the Kobuk team.
Projects
None yet
Milestone
No milestone
3 participants
@Batta32 @CezaryMarcjan @peterinnesmsft