This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[C#][Bot-Solutions] Rehome used services of Microsoft.Bot.Configuration to Microsoft.Bot.Solutions in Services folder #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig,
sidmore and
taicchoumsft
|
Hey @Batta32, I'm not sure the right path forward on this one is to mark these properties as obsolete. I'm assuming we are still ultimately need these in the current Virtual Assistant. If there's an alternative to LuisService that we are intended to be using, then I think we should figure out what that is. Let's discuss and we can figure out a path forward with the SDK team. |
peterinnesmsft
suggested changes
Aug 13, 2020
|
@peterinnesmsft - Sure! At the meantime, I'll change this PR to draft and we will review another alternatives with the team 😊. |
Batta32
changed the title
|
@peterinnesmsft - we finished doing the rehome of the used services of |
peterinnesmsft
added
the
Language: C#
peterinnesmsft
approved these changes
Sep 1, 2020
2 tasks
lauren-mills
suggested changes
Sep 1, 2020
sdk/csharp/libraries/microsoft.bot.solutions/Services/ConnectedService.cs
Outdated
Show resolved
Hide resolved
lauren-mills
approved these changes
Sep 2, 2020
2 tasks
peterinnesmsft
added
PR: reviewed-approved
and removed
PR: partially-approved
PR: reviewed-changes-requested
PR: unreviewed
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3617
Purpose
What is the context of this pull request? Why is it being done?
With the new Microsoft.Bot.Builder@4.10.0 packages, the LuisService class has been deprecated so Bot-Solutions doesn't build as it runs into a "LuisService is obsolete: This class is deprecated" error.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Rehome the used Services of Microsoft.Bot.Configuration to Microsoft.Bot.Solutions:
Tests
Is this covered by existing tests or new ones? If no, why not?
We tested the C# solutions, after apply this fix, manually and worked as expected.
Successfully communication in Emulator
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General