Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Various docs issues #2310

Merged
merged 6 commits into from
Sep 10, 2019
Merged

Various docs issues #2310

merged 6 commits into from
Sep 10, 2019

Conversation

ryanisgrig
Copy link
Collaborator

@ryanisgrig ryanisgrig commented Sep 5, 2019

Purpose

What is the context of this pull request? Why is it being done?
Close #2309 by adding additional details to the experimental skills page regarding configuration and integrating event activities
image

Close #2294 by updating each skill's README with an aka.ms link to the appropriate doc resource
Close #2288 by updating the To Do Skill's documentation and manifest file with an additional User.Read scope
Close #2274 by clarifying instructions in the VA Getting Started tutorial on getting LUIS credentials
Close #2332 adding a note to escape special characters

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
n/a

Tests

Is this covered by existing tests or new ones? If no, why not?
n/a

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
n/a

Checklist

General

  • I have updated related documentation

@darrenj darrenj merged commit 6d44f8f into next Sep 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the ryanlengel/various_doc_updates branch September 10, 2019 14:17
@@ -25,6 +25,8 @@ When deployment is complete, you can run your Virtual Assistant debugging throug

4. Populate the fields in the **Open a Bot** modal with your bot's configuration settings. Provide the endpoint of your running bot, e.g: `http://localhost:3978/api/messages`. Provide the AppId and Secret values. Find these in your `appsettings.json` file, under the `microsoftAppId` and `microsoftAppPassword` configuration settings.

> **Note**: If you password has any JSON reserved characters (backslash, quote, etc.), they must be properly escaped to connect to your bot.
Copy link
Contributor

@ppaltmann ppaltmann Sep 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ryanlengel,

it is the other way around. If you enter the password with the slash inside of your deployment scripts (VA tutorial) it will be AUTOMATICALLY escaped. You don't need to do it by yourself. The problem is that this is happening without notice and when you follow the tutorial then you don't know that this operation happened and copy the wrong password out of the appsettings.json.

This means keep on eye on the appsettings.json if your password had escaped characters which you need to remove before entering it in the Bot Emulator.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - will fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants