This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Merging from next #2965
Merged
Merging from next #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildServiceProvider and runtime one are not same one
Hospitality, POI, ITSM
…#2585) * Changed routerDialog to dispatchDialog and deprecated routerDialog * renamed dispatchDialog to activityHandlerDialog * changed deprecation message * reverted project changes * reverted changes to sample * updated summaries and comments * Update RouterDialog.cs * readme * added myget to build.props for libs
* main dialog changes * updated packages * removed unused nuget package * updated build props to remove declarative source * updated comments and moved const fields * small comment update
If not fix, it will return empty list
* fix email doc * fix comments * Fix comments
* [ITSM][POI] transcripts POI * Fix converting AzureMaps * Convert Foursquare in transcript ITSM * "ShowExistingToSolve" before searching knowledgebase before creating ticket (already included in transcript) * rephrase converting to data uri
* EventProducer: add userid to app settings and variables in program.cs for all app settings. VASample: add proactive notifications support * Move event handler and producer projects to samples/csharp/clients so that they can be shared with other assistant samples in the future. * Add rouge highlighter for code syntax highlighting Begin conversion of existing Enterprise Notifications doc to Enable Proactive Notifications tutorial * Update tutorial doc * update comments in eventhandler * Rename event sample directories with hyphens for spacing
* Add crash SDK and telemetry for Activity Sent, Activity Received, Send VA.Location Event * Start analytics in app * Update doc with improved padding Add empty doc for event companion Update virtual assistant client doc with screenshots * Remove typo * Fix toc * updated docs of event companion app
* updated packages * cleaned up comments * cleanup * small update
* update doc and code * update test * fix comments
* add tel prefix in telephone uri * add poi tel prefix
* update skills sdk to new rc * add botbuilder daily build feed
* Added What's New Content to Docs Site * Fix whats new intro
* Navigation Structure for Docs Update * Move tutorials * Move notifications and analytics tutorials
* Add support for two manifests models * Add utils to validate schemas * Update classes to support V1 schema * Add connect support for both schemas * Add Update support for both schemas * Add Disconnect support for both schemas * Remove --skillsFile argument in connect command * Remove –skillsFile argument in update command * Remove unnecesary method * Remove skillsFile argument from disconnect * Update logic to read the container of skills * Remove unnecesary console.logs for schema validation * Unify duplicated code * Remove ITU properties * Remove ITU documentation * Remove ITU on refresh command * Remove ITU on update command * Generate .luis files with url value of new schema * Add name property to appsettings (#197) Co-authored-by: Victor Grycuk <victor.grycuk@southworks.com> * Add SkillHostEndpoint property in appsettings (#199) * Add skillHostEndpoint property and assign it * Fix casing Co-Authored-By: Martin Battaglino <martinbatta32@gmail.com> * Fix casing Co-Authored-By: Martin Battaglino <martinbatta32@gmail.com> * Fix casing Co-Authored-By: Martin Battaglino <martinbatta32@gmail.com> * Update validation Co-authored-by: Victor Grycuk <victor.grycuk@southworks.com> * Refactor of executionModel method (#198) * Fix creation of luis file * Add tolowercase for luis creation file Co-authored-by: Luis Sergio <37625424+LCarbonellRod@users.noreply.github.com> Co-authored-by: Victor Grycuk <victor.grycuk@southworks.com>
* fix calendar * fix email * fix todo * translate todo * translate calendar * translate todo * todo draft * refactor todo lg files * email lg * lg calendar * remove some comments
Co-authored-by: Victor Grycuk <victor.grycuk@southworks.com>
* skill template style fix * Updated VA template
* add doc to achieve skill sso * updates Co-authored-by: Darren Jefford <33519520+darrenj@users.noreply.github.com>
* Updated ToDo Skill to use waterfall main dialog * Updated POI skill to waterfall main dialog * update email skill to waterfall dialog * updated calendar skill to waterfall dialog
* add migrate va to 0.8 doc * resolve comment * migration docs Co-authored-by: Darren Jefford <33519520+darrenj@users.noreply.github.com>
auto-assign
bot
requested review from
darrenj,
lzc850612,
pavolum and
ryanisgrig
lzc850612
approved these changes
Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General
Bots
.lufiles and validated that deployment is successfulDeployment Scripts