This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[TypeScript][GA Skills SDK] Update Documentation for VA/Skill Samples #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfavretto
commented
Feb 28, 2020
There was a problem hiding this comment.
This document is still in progress, we marked some observations to take into account for the moment. The most important thing to be remarked is the name and location of this file, now that there are 2 similar files for the different languages, maybe we can divide them into different folders.
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
| "botbuilder-lg": "4.7.2-preview" | ||
| ``` | ||
|
|
||
| 1. Use local `botbuilder-solutions` package. This will require to *change* all the internal references of `botbuilder-skills` to `botbuilder-solutions` and remove `botbuilder-skills` library. |
There was a problem hiding this comment.
In case PR #3122 gets merged and a new version is published, we can indicate to use that botbuilder-solutions package.
There was a problem hiding this comment.
About using botbuilder-solutions package, could you specify where to get the version? I guess in the southwork branch but I would like to be sure.
There was a problem hiding this comment.
Yes we can simultaneously do it
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
3 tasks
darrenj
suggested changes
Mar 2, 2020
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
docs/_docs/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8 - TypeScript.md
Outdated
Show resolved
Hide resolved
tommyJimmy87
reviewed
Mar 3, 2020
Batta32
changed the title
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig,
sidmore and
taicchoumsft
darrenj
approved these changes
Apr 9, 2020
delete-merged-branch
bot
deleted the
feature/southworks/ga-skills-sdk/migration-documentation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2489
Purpose
What is the context of this pull request? Why is it being done?
Give detailed indications on how to migrate an existing Virtual Assistant and Skill to support the GA Skills SDK changes.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Update the migration bots document in order to incorporate the GA Skills SDK changes for the Virtual Assistant and Skill.
Tests
Is this covered by existing tests or new ones? If no, why not?
-
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General