This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Concat texts for multiturn responses in Interactions table #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig and
sidmore
and removed request for
a team
pavolum
approved these changes
Jun 16, 2020
|
should this PR go in Master or next? #Resolved |
lauren-mills
approved these changes
Jun 22, 2020
ryanisgrig
approved these changes
Jun 22, 2020
|
Thanks for catching this Sid, switched base to next. In reply to: 647660316 [](ancestors = 647660316) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Partially resolves #3447
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp?
Please see the bug report for details of the changes.
There is only a single change to change the aggregation of BotResponseText in the Interactions table from "Max" to "Text.combine"
Tests
Is this covered by existing tests or new ones? If no, why not?
No tests cover our PBI template
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
No steps remaining
Checklist
General
Please help by testing the template for any possible breaks. Thanks!