Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update angular version to 8, web.config fix, add badge to readme #6

Merged
merged 2 commits into from Jun 26, 2019
Merged

update angular version to 8, web.config fix, add badge to readme #6

merged 2 commits into from Jun 26, 2019

Conversation

j-windsor
Copy link
Contributor

No description provided.

wswiatek
wswiatek suggested changes Jun 26, 2019
View reviewed changes
Copy link

@wswiatek wswiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider running Angular 8 CLI against new project on the side and compare package.json to make sure versions match more closely.
Also, e2e will become part of the project (and not a separate one) - so angular.json changes might be needed as well.

@j-windsor j-windsor requested a review from wswiatek June 26, 2019 23:34
@j-windsor j-windsor merged commit 576b682 into master Jun 26, 2019
@j-windsor j-windsor deleted the jawindso-updateAngular branch June 27, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswiatek wswiatek wswiatek approved these changes

@kart-naga kart-naga kart-naga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-windsor @wswiatek @kart-naga