Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pan/Zoom support for the graph surface #458

Conversation

danbelcher-MSFT
Copy link

Description of the changes:

Add Pan/Zoom support for the graph surface.

  • Currently only supports Mouse/Pen/Touch interactions. Keyboard support will be added separately.

How changes were validated:

Manual

Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is working great, left a few comments.

src/GraphControl/Control/Grapher.cpp Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Outdated Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Outdated Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Outdated Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Outdated Show resolved Hide resolved
src/GraphControl/Control/Grapher.cpp Outdated Show resolved Hide resolved
joseartrivera
joseartrivera previously approved these changes Apr 22, 2019
@danbelcher-MSFT danbelcher-MSFT merged commit 5ffe1bc into microsoft:feature/GraphingCalculator Apr 22, 2019
@danbelcher-MSFT danbelcher-MSFT deleted the feature/GraphingCalculator-PanZoom branch April 22, 2019 21:30
EriWong pushed a commit to EriWong/calculator that referenced this pull request Jun 5, 2019
Description of the changes:
Add Pan/Zoom support for the graph surface.
Currently only supports Mouse/Pen/Touch interactions. Keyboard support will be added separately.

How changes were validated:
Manual
@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement fixing approved issue graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants