Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Tests YAML updated to integrate WinAppDriver task #480

Merged
merged 2 commits into from Apr 30, 2019

Conversation

hassanuz
Copy link
Contributor

@hassanuz hassanuz commented Apr 29, 2019

New WinAppDriver task for Azure Pipelines was recently released. YAML has been updated to reference it.

The task will have to be manually installed from the DevOps marketplace for the pipeline to be successful.

Fixes #.

Description of the changes:

  • Removed step powershell script to adjust agent resolution
  • Removed step for powershell script to start WinAppDriver on agent
  • Added step for WinAppDriver Task to Start WinAppDriver & adjust resolution
  • Added step for WinAppDriver Task to Stop WinAppDriver & fetch logs

How changes were validated:

  • Valided bits on private pipeline.

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these changes look good. I'll leave it to our yaml expert, @mcooley to make the final call. Thanks for updating these to the new official tasks!

@mcooley
Copy link
Member

mcooley commented Apr 29, 2019

Looks good to me. We will need to get the task installed into our Azure DevOps org. I've submitted a request for that and am waiting to hear back.

@mcooley
Copy link
Member

mcooley commented Apr 30, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mcooley mcooley merged commit 94a90d7 into microsoft:master Apr 30, 2019
EriWong pushed a commit to EriWong/calculator that referenced this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants