Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds zoom buttons to graph controls #637

Merged
merged 8 commits into from Aug 16, 2019
Merged

Adds zoom buttons to graph controls #637

merged 8 commits into from Aug 16, 2019

Conversation

greedyAI
Copy link
Contributor

@greedyAI greedyAI commented Aug 8, 2019

Description of the changes:

  • Zoom-in and zoom-out buttons have been added. When clicked or pressed, they call GraphingControl's ScaleRange function. These buttons take advantage of RepeatButton's API to allow for hold-down repeat click behavior.
  • Zoom reset button has been added. When clicked or pressed, it calls GraphingControl's ResetGrid function.
  • Appropriate keyboard shortcuts and light-mode styling for these buttons have also been added.

How changes were validated:

  • Manual testing.

Copy link
Contributor

@rudyhuyn rudyhuyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Wei!

I've added a few comments, let me know what you think!

⚠ It seems that your Visual Studio doesn't use XAML Styler (https://marketplace.visualstudio.com/items?itemName=TeamXavalon.XAMLStyler), check that this extension is installed and enabled. Once done, save GraphingCalculator.xaml again to format the XAML code.

@grochocki grochocki added the graphing calculator Work items related to the graphing calculator feature. label Aug 9, 2019
@ghost ghost removed the needs author feedback label Aug 16, 2019
@joseartrivera joseartrivera merged commit 1c9755d into microsoft:feature/GraphingCalculator Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants