Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color picker #668

Conversation

joseartrivera
Copy link
Contributor

@joseartrivera joseartrivera commented Sep 11, 2019

Part of #338

Description of the changes:

  • Update color picker to use defined set of colors instead of the default color picker
  • Don't reinitialize the graph when changing colors
  • Some code and UI clean up

How changes were validated:

  • Manual testing

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Sep 11, 2019
Copy link
Contributor

@rudyhuyn rudyhuyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments!

src/Calculator/StylePanel.xaml Outdated Show resolved Hide resolved
src/Calculator/StylePanel.xaml.h Outdated Show resolved Hide resolved
src/Calculator/StylePanel.xaml Outdated Show resolved Hide resolved
src/Calculator/StylePanel.xaml Outdated Show resolved Hide resolved
src/Calculator/StylePanel.xaml.cpp Outdated Show resolved Hide resolved
@ghost ghost removed the needs author feedback label Sep 25, 2019
@joseartrivera joseartrivera merged commit 7864fe6 into microsoft:feature/GraphingCalculator Sep 25, 2019
DavidShoe pushed a commit to DavidShoe/calculator that referenced this pull request Oct 29, 2019
DavidShoe pushed a commit to DavidShoe/calculator that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement fixing approved issue graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants