-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active tracing #702
Active tracing #702
Conversation
…inpage to graphingcalculator
… of a failure. Then add the equations key.
…till need to do the graph equation key.
Feature/graphing calculator update from microsoft master repo.
Working -> feature branch so can validate then pull to main project from fork.
Fixed Co-Authored-By: Pepe Rivera <joseartrivera@gmail.com>
…ops. Also block tracking of the active tracing key's when in the EquationTextBox.
PR Updates.
… automatically change depending on system values. And changed text formatting of the value to be generic (x,y) value.
…when not in active tracing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should tracing only be disabled using the toggle button? Right now it is also disabled when clicking in the equation edit box.
You can break out of active tracing by doing other actions like adding a new equation or editing an existing one. |
When I used it, I thought it was weird that only clicking in the EquationEditBox would toggle off focus and not clicking the gray area below the EquationEditBox. I think it would be best to just use the toggle button so that a stray click cannot accidentally turn it off. |
I'm going to approve this in because it fixes the toggle button issue. I think we should file a bug to track if a click outside the graph area should turn off tracing. |
Fixes #.
Description of the changes:
How changes were validated: