Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active tracing #702

Merged
merged 46 commits into from
Oct 10, 2019
Merged

Conversation

DavidShoe
Copy link
Contributor

Fixes #.

Description of the changes:

How changes were validated:

DavidShoe and others added 30 commits July 12, 2019 15:19
Feature/graphing calculator update from microsoft master repo.
Working -> feature branch so can validate then pull to main project from fork.
Fixed

Co-Authored-By: Pepe Rivera <joseartrivera@gmail.com>
…ops.

Also block tracking of the active tracing key's when in the EquationTextBox.
Copy link
Contributor

@sanderl sanderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should tracing only be disabled using the toggle button? Right now it is also disabled when clicking in the equation edit box.

@grochocki
Copy link
Contributor

Should tracing only be disabled using the toggle button? Right now it is also disabled when clicking in the equation edit box.

You can break out of active tracing by doing other actions like adding a new equation or editing an existing one.

@sanderl
Copy link
Contributor

sanderl commented Oct 7, 2019

Should tracing only be disabled using the toggle button? Right now it is also disabled when clicking in the equation edit box.

You can break out of active tracing by doing other actions like adding a new equation or editing an existing one.

When I used it, I thought it was weird that only clicking in the EquationEditBox would toggle off focus and not clicking the gray area below the EquationEditBox. I think it would be best to just use the toggle button so that a stray click cannot accidentally turn it off.

@HowardWolosky HowardWolosky added the graphing calculator Work items related to the graphing calculator feature. label Oct 8, 2019
@sanderl
Copy link
Contributor

sanderl commented Oct 10, 2019

I'm going to approve this in because it fixes the toggle button issue. I think we should file a bug to track if a click outside the graph area should turn off tracing.

@sanderl sanderl merged commit 65c3046 into microsoft:feature/GraphingCalculator Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants