Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 505 #710

Merged
merged 2 commits into from Oct 13, 2019
Merged

fix 505 #710

merged 2 commits into from Oct 13, 2019

Conversation

Grommers00
Copy link
Contributor

@Grommers00 Grommers00 commented Oct 11, 2019 •
edited

Fixes #505 .

Description of the changes:

  • Changed all the E_CODE_* Variables located in CalcErr.h from Macros to static const expr (inline is implicite)

How changes were validated:

  • Manual-Adhoc testing

@msftclas
Copy link

msftclas commented Oct 11, 2019 •
edited

CLA assistant check
All CLA requirements met.

@HowardWolosky HowardWolosky added codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) fixing approved issue labels Oct 11, 2019
@Grommers00
Update CalcErr.h
6fbdf8b 
Updated to have line of code changed to be right below the comment referring to line of code. (Line 45-44)
@Grommers00
Copy link
Contributor Author

I have updated the code to remove the white line space.

Is there anything else I need to do?

EriWong
EriWong approved these changes Oct 13, 2019
View reviewed changes
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this!

@EriWong EriWong merged commit 033f775 into microsoft:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky left review comments

@EriWong EriWong EriWong approved these changes

Assignees

@EriWong EriWong

Labels
codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) fixing approved issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CALC_E_* to no longer use macros
4 participants
@Grommers00 @msftclas @EriWong @HowardWolosky