Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus for EquationTextBox #787

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fix focus for EquationTextBox #787

merged 1 commit into from
Nov 13, 2019

Conversation

joseartrivera
Copy link
Contributor

Part of #338

Description of the changes:

  • After submitting an equation with the enter key we should move focus away from the EquationTextBox . Previously this would happen anytime the equation was submitted, now it only occurs if it was submitted and the EquationTextBox has focus, allowing the user to tab away to submit and keep focus flowing to the next element as normal.

How changes were validated:

  • Manual tests

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Nov 8, 2019
sanderl
sanderl reviewed Nov 8, 2019
View reviewed changes
src/Calculator/Controls/EquationTextBox.cpp
@@ -144,7 +144,7 @@ void EquationTextBox::OnRichEditBoxTextChanged(Object ^ sender, RoutedEventArgs

void EquationTextBox::OnRichEditBoxGotFocus(Object ^ sender, RoutedEventArgs ^ e)
{
m_isFocused = true;
m_HasFocus = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only for RichEditFocus of for the whole control?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the whole control, but currently we only care when the RichEditBox gets focus

sanderl
sanderl approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@sanderl sanderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed some weird behavior where tab navigation shows up after pressing enter even if it wasn't used before pressing enter.

@joseartrivera joseartrivera merged commit afc1b21 into microsoft:feature/GraphingCalculator Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderl sanderl sanderl approved these changes

Assignees

@sanderl sanderl

Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joseartrivera @sanderl