Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only NumberBase to represent radix in CalcViewModel #797

Merged
merged 1 commit into from Nov 14, 2019
Merged

Use only NumberBase to represent radix in CalcViewModel #797

merged 1 commit into from Nov 14, 2019

Conversation

rudyhuyn
Copy link
Contributor

Fixes #796

Description of the changes:

  • simply replace RADIX_TYPE and int types used to represent radix by NumberBase

How changes were validated:

  • manually

@mcooley mcooley self-assigned this Nov 14, 2019
mcooley
mcooley approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@mcooley mcooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mcooley mcooley merged commit 1380c7e into microsoft:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcooley mcooley mcooley approved these changes

Assignees

@mcooley mcooley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CalcViewModel should only use one type to represent radix
2 participants
@rudyhuyn @mcooley