Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling to graph and equations #827

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Add error handling to graph and equations #827

merged 5 commits into from
Dec 3, 2019

Conversation

joseartrivera
Copy link
Contributor

Part of #338

Description of the changes:

  • Updates graph control to flag equations if they fail to graph
  • Updates graph control to flag equations if they successfully graph
  • Graph control will not try to graph any equations that have previously failed, unless their expression has changed
  • When graphing an equation that was previously successful, if the graphing fails, we will flag that equation and try graphing again without it
  • Added UI to indicate that an equation has failed to graph
  • Some other code tweaks

How changes were validated:

  • Manual tests

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Nov 25, 2019
EriWong
EriWong approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and buddy testing went well.

@joseartrivera joseartrivera reopened this Dec 3, 2019
@mcooley
Copy link
Member

mcooley commented Dec 3, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EriWong EriWong merged commit 89c3fc3 into microsoft:feature/GraphingCalculator Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderl sanderl sanderl left review comments

@EriWong EriWong EriWong approved these changes

Assignees

@sanderl sanderl

Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joseartrivera @mcooley @EriWong @sanderl