Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up keyboard in graphing calculator #863

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Wire up keyboard in graphing calculator #863

merged 3 commits into from
Dec 19, 2019

Conversation

EriWong
Copy link
Contributor

@EriWong EriWong commented Dec 12, 2019

Fixes part of #338.

Description of the changes:

Wires up on screen keyboard to behave like a SIP for the last focused equation text box.

How changes were validated:

manually

@EriWong EriWong added the graphing calculator Work items related to the graphing calculator feature. label Dec 12, 2019
joseartrivera
joseartrivera reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is looking really good, I found a few corner case issues that I think we will want to address, but overall this is looking fantastic! Thanks!

src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.h Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp Outdated Show resolved Hide resolved
joseartrivera
joseartrivera requested changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates, this is working much better. I found a few corner cases for you to consider, lmk what you think! Thanks again.

src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml Show resolved Hide resolved
src/CalcViewModel/Common/CalculatorButtonUser.h Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp Outdated Show resolved Hide resolved
joseartrivera
joseartrivera approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Congrats on getting this working so nicely 🔥

@joseartrivera joseartrivera merged commit 13e3179 into microsoft:feature/GraphingCalculator Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseartrivera joseartrivera joseartrivera approved these changes

Assignees
No one assigned
Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EriWong @joseartrivera