Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graph tooltip design and content #867

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Update graph tooltip design and content #867

merged 2 commits into from
Dec 16, 2019

Conversation

rudyhuyn
Copy link
Contributor

Description of the changes:

  • Rollback text formatting change:
    • Before: x=22, y=32
    • After: (22, 32)
  • Update design of the tooltip

image

How changes were validated:

  • manually, with all themes

@rudyhuyn rudyhuyn changed the base branch from master to feature/GraphingCalculator December 13, 2019 12:15
@rudyhuyn
Copy link
Contributor Author

cc @grochocki

@mdtauk
Copy link

mdtauk commented Dec 13, 2019

Is it not missing a shadow?

@EriWong EriWong added the graphing calculator Work items related to the graphing calculator feature. label Dec 13, 2019
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks less cluttered than before. @rudyhuyn, Thanks for making this change. @mdtauk, thanks for the comment. We'll likely do another overall UI pass and I've captured your feedback on the shadow internally to make sure it doesn't get lost. In this particular case, I don't want to block on it as the cleaner UI is the main goal of this PR.

@EriWong EriWong merged commit fe599e3 into microsoft:feature/GraphingCalculator Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants