This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bongshin
approved these changes
Apr 27, 2021
bongshin
pushed a commit
that referenced
this pull request
May 20, 2021
* Fix plotsegment axis names (#480) * Fix prettyNumber function (#482) * Fix axis. Update title of data mapping dialog (#487) * Fix axis data rebinding * Update mapping data dialog titles * Change the first column header (#488) * Disable sorting property of plot segment if auto ranges was disabled (#489) Co-authored-by: bongshin <bongshin@microsoft.com> * Set correct table name (#490) * Update data axis range values on replacing dataset (#486) * Update data axis range values on replacing dataset * Fix axis data rebinding * Rework code * Get get data kind by type on updating axes * Update visual style of guide coordinator (#491) * Update visual style of guide coordinator * Remove unused attributes * Change line style * Update styles Co-authored-by: bongshin <bongshin@microsoft.com> * Guide rollback (#495) * Rollback guide coordinator configuration * Increase version number to 2.0.3 Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Format validator widget for attributes editor (#492) * Format validator widget for attributes editor * Set regexp as constant * Add "(auto)", "(none)" to strings * Fix tests * Wrap regex to function Co-authored-by: bongshin <bongshin@microsoft.com> * Fix regex (#497) * Fix regex * Add test * Fix scale editor bug (#498) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix rendering text twice when text wrap is enabled for axis (#500) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Tslint => eslint (#496) * Replace Array<> by [] * Replace "as" cast by "<>" * Add eslint * Fix eslint issues * Update code * Fix merge issues * Fix worker * react-hooks plugin for eslint. Fix warnings Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * View configuration (#502) * Expose main view config * Change save button state Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Add Segoe UI into fonts list (#504) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Remove tslint config (#506) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Allow map any data type to string (#501) * Allow map any data type to string * Import DataType Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Don't render guide coordinator handles in plot segment (#508) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix svg headers (#509) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Rounded border (#503) * Rounded border of canvas view * Unify rect path function Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Show report issue button for visual (#507) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Save old name/id of expression to hold binding marks to those axis points (#513) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set default value of interactivity properties for marks (#514) * Set default value of interactivity properties for marks * Set guide coordinator guides default count to 2 Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix app initialization (#515) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix saving tick format for axes (#516) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Add checks for properties (#517) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Quantile Expressions and Helpers (#511) Added a `quantile` function, which accepts a percentage value as input, plus the field array, which can be used to calculate quantiles wherever expressions are used. Additionally, I've added the following functions as shortcuts (plus helpers): - `quartile1` (1st Quartile) - `quartile3` (3rd Quartile) - `iqr` (Inter-Quartile Range) Resolves #499 * Set Overlap sublayout to the end of sublayout list (#518) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Link anchors (#520) * Add link anchors to line object * Bind links to glyph center if no marks with anchor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Display date instead number in scale editor (#524) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set Segoe UI as default font (#525) * Set Segoe UI as default font * Set default font size 12 for text and text box * Fix unit tests * Add constant for default font size Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Save order from template for axes categorical values (#522) * Save order from template for axes categorical values * Fix issues * Keep sorting order on updating plot segments Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Update yarn.lock * Fix updating domain for scales (#526) * Fix updating domain for scales. Change layout of scale editor and labels. Set defaults for data axis. * Update comment Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Replace constant strings by strings object (#493) * Replace constant strings by strings object * Fix updating domain for scales. Change layout of scale editor and labels. Set defaults for data axis. * Update comment * Add string constants for scale and axis Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Expose nested chart columns on export (#527) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Bump lodash from 4.17.19 to 4.17.21 (#529) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.19...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix creating the new scale (#530) * Fix creating the new scale * Fix reset of scales Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Set defaults for data axis (#532) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Remove default attributes for data axis (#533) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Exclude attributes on comparing chart states (#531) * Exclude attributes on comparing chart states * Remove commented code * Remove unused import * Add constant for approximation. Check constraints by expect_deep_approximately_equals * Add comment for normalizeDataExpression method * Add comment * Fix rawExpressions for axis data bindings * Fix height of canvas toolbar Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Include valueIndex property of scale as null into template (#538) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Change anchor element for color picker for empty property (#539) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set default aggregation function "first" for categorical values (#536) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix guide mapping (#540) * Fix data mapping to guide value * Fix attribute mapping on drag guide in mark editor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: Daniel Marsh-Patrick <daniel@coacervo.co> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
bongshin
pushed a commit
that referenced
this pull request
May 31, 2021
* Fix plotsegment axis names (#480) * Fix prettyNumber function (#482) * Fix axis. Update title of data mapping dialog (#487) * Fix axis data rebinding * Update mapping data dialog titles * Change the first column header (#488) * Disable sorting property of plot segment if auto ranges was disabled (#489) Co-authored-by: bongshin <bongshin@microsoft.com> * Set correct table name (#490) * Update data axis range values on replacing dataset (#486) * Update data axis range values on replacing dataset * Fix axis data rebinding * Rework code * Get get data kind by type on updating axes * Update visual style of guide coordinator (#491) * Update visual style of guide coordinator * Remove unused attributes * Change line style * Update styles Co-authored-by: bongshin <bongshin@microsoft.com> * Guide rollback (#495) * Rollback guide coordinator configuration * Increase version number to 2.0.3 Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Format validator widget for attributes editor (#492) * Format validator widget for attributes editor * Set regexp as constant * Add "(auto)", "(none)" to strings * Fix tests * Wrap regex to function Co-authored-by: bongshin <bongshin@microsoft.com> * Fix regex (#497) * Fix regex * Add test * Fix scale editor bug (#498) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix rendering text twice when text wrap is enabled for axis (#500) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Tslint => eslint (#496) * Replace Array<> by [] * Replace "as" cast by "<>" * Add eslint * Fix eslint issues * Update code * Fix merge issues * Fix worker * react-hooks plugin for eslint. Fix warnings Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * View configuration (#502) * Expose main view config * Change save button state Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Add Segoe UI into fonts list (#504) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Remove tslint config (#506) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Allow map any data type to string (#501) * Allow map any data type to string * Import DataType Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Don't render guide coordinator handles in plot segment (#508) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix svg headers (#509) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Rounded border (#503) * Rounded border of canvas view * Unify rect path function Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Show report issue button for visual (#507) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Save old name/id of expression to hold binding marks to those axis points (#513) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set default value of interactivity properties for marks (#514) * Set default value of interactivity properties for marks * Set guide coordinator guides default count to 2 Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix app initialization (#515) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix saving tick format for axes (#516) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Add checks for properties (#517) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Quantile Expressions and Helpers (#511) Added a `quantile` function, which accepts a percentage value as input, plus the field array, which can be used to calculate quantiles wherever expressions are used. Additionally, I've added the following functions as shortcuts (plus helpers): - `quartile1` (1st Quartile) - `quartile3` (3rd Quartile) - `iqr` (Inter-Quartile Range) Resolves #499 * Set Overlap sublayout to the end of sublayout list (#518) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Link anchors (#520) * Add link anchors to line object * Bind links to glyph center if no marks with anchor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Display date instead number in scale editor (#524) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set Segoe UI as default font (#525) * Set Segoe UI as default font * Set default font size 12 for text and text box * Fix unit tests * Add constant for default font size Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Save order from template for axes categorical values (#522) * Save order from template for axes categorical values * Fix issues * Keep sorting order on updating plot segments Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix updating domain for scales (#526) * Fix updating domain for scales. Change layout of scale editor and labels. Set defaults for data axis. * Update comment Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Replace constant strings by strings object (#493) * Replace constant strings by strings object * Fix updating domain for scales. Change layout of scale editor and labels. Set defaults for data axis. * Update comment * Add string constants for scale and axis Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Expose nested chart columns on export (#527) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Bump lodash from 4.17.19 to 4.17.21 (#529) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.19...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix creating the new scale (#530) * Fix creating the new scale * Fix reset of scales Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Set defaults for data axis (#532) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Remove default attributes for data axis (#533) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Exclude attributes on comparing chart states (#531) * Exclude attributes on comparing chart states * Remove commented code * Remove unused import * Add constant for approximation. Check constraints by expect_deep_approximately_equals * Add comment for normalizeDataExpression method * Add comment * Fix rawExpressions for axis data bindings * Fix height of canvas toolbar Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Include valueIndex property of scale as null into template (#538) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Change anchor element for color picker for empty property (#539) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set default aggregation function "first" for categorical values (#536) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix guide mapping (#540) * Fix data mapping to guide value * Fix attribute mapping on drag guide in mark editor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Add getState, setState to History Mananger. Remove some intermediate states from history (#542) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Don't reset history manager on import template or dataset (#547) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix size of drop area indicator for mapping editor (#551) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fixes (#552) * Set border for color picker in chart attribute * Update data kind on changing type * Scroll to attribute field on opening editor from Scale editor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Change default color from grey to blue (#543) * Change default color from grey to blue * Change color to skyblue Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix popup panel position for attributes panel (#555) * Fix popup panel position for attributes panel * Fix popup anchor container Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: Daniel Marsh-Patrick <daniel@coacervo.co> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
bongshin
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Fix plotsegment axis names (#480) * Fix prettyNumber function (#482) * Fix axis. Update title of data mapping dialog (#487) * Fix axis data rebinding * Update mapping data dialog titles * Change the first column header (#488) * Disable sorting property of plot segment if auto ranges was disabled (#489) Co-authored-by: bongshin <bongshin@microsoft.com> * Set correct table name (#490) * Update data axis range values on replacing dataset (#486) * Update data axis range values on replacing dataset * Fix axis data rebinding * Rework code * Get get data kind by type on updating axes * Update visual style of guide coordinator (#491) * Update visual style of guide coordinator * Remove unused attributes * Change line style * Update styles Co-authored-by: bongshin <bongshin@microsoft.com> * Guide rollback (#495) * Rollback guide coordinator configuration * Increase version number to 2.0.3 Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Format validator widget for attributes editor (#492) * Format validator widget for attributes editor * Set regexp as constant * Add "(auto)", "(none)" to strings * Fix tests * Wrap regex to function Co-authored-by: bongshin <bongshin@microsoft.com> * Fix regex (#497) * Fix regex * Add test * Fix scale editor bug (#498) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix rendering text twice when text wrap is enabled for axis (#500) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Tslint => eslint (#496) * Replace Array<> by [] * Replace "as" cast by "<>" * Add eslint * Fix eslint issues * Update code * Fix merge issues * Fix worker * react-hooks plugin for eslint. Fix warnings Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * View configuration (#502) * Expose main view config * Change save button state Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Add Segoe UI into fonts list (#504) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Remove tslint config (#506) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Allow map any data type to string (#501) * Allow map any data type to string * Import DataType Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Don't render guide coordinator handles in plot segment (#508) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix svg headers (#509) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Rounded border (#503) * Rounded border of canvas view * Unify rect path function Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Show report issue button for visual (#507) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Save old name/id of expression to hold binding marks to those axis points (#513) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set default value of interactivity properties for marks (#514) * Set default value of interactivity properties for marks * Set guide coordinator guides default count to 2 Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix app initialization (#515) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix saving tick format for axes (#516) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Add checks for properties (#517) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Quantile Expressions and Helpers (#511) Added a `quantile` function, which accepts a percentage value as input, plus the field array, which can be used to calculate quantiles wherever expressions are used. Additionally, I've added the following functions as shortcuts (plus helpers): - `quartile1` (1st Quartile) - `quartile3` (3rd Quartile) - `iqr` (Inter-Quartile Range) Resolves #499 * Set Overlap sublayout to the end of sublayout list (#518) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Link anchors (#520) * Add link anchors to line object * Bind links to glyph center if no marks with anchor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Display date instead number in scale editor (#524) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set Segoe UI as default font (#525) * Set Segoe UI as default font * Set default font size 12 for text and text box * Fix unit tests * Add constant for default font size Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Save order from template for axes categorical values (#522) * Save order from template for axes categorical values * Fix issues * Keep sorting order on updating plot segments Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix updating domain for scales (#526) * Fix updating domain for scales. Change layout of scale editor and labels. Set defaults for data axis. * Update comment Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Replace constant strings by strings object (#493) * Replace constant strings by strings object * Fix updating domain for scales. Change layout of scale editor and labels. Set defaults for data axis. * Update comment * Add string constants for scale and axis Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Expose nested chart columns on export (#527) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Bump lodash from 4.17.19 to 4.17.21 (#529) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.19...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix creating the new scale (#530) * Fix creating the new scale * Fix reset of scales Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Set defaults for data axis (#532) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Remove default attributes for data axis (#533) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Exclude attributes on comparing chart states (#531) * Exclude attributes on comparing chart states * Remove commented code * Remove unused import * Add constant for approximation. Check constraints by expect_deep_approximately_equals * Add comment for normalizeDataExpression method * Add comment * Fix rawExpressions for axis data bindings * Fix height of canvas toolbar Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Include valueIndex property of scale as null into template (#538) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Change anchor element for color picker for empty property (#539) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set default aggregation function "first" for categorical values (#536) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix guide mapping (#540) * Fix data mapping to guide value * Fix attribute mapping on drag guide in mark editor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Add getState, setState to History Mananger. Remove some intermediate states from history (#542) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Don't reset history manager on import template or dataset (#547) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix size of drop area indicator for mapping editor (#551) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fixes (#552) * Set border for color picker in chart attribute * Update data kind on changing type * Scroll to attribute field on opening editor from Scale editor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Change default color from grey to blue (#543) * Change default color from grey to blue * Change color to skyblue Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> * Fix popup panel position for attributes panel (#555) * Fix popup panel position for attributes panel * Fix popup anchor container Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Call chart migrator on launching nested chart editor (#558) * Call chart migrator on launching nested chart editor * Remove unused variables. * Set null for categories property of axis * Remove replaceUndefinedByNull Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Rollback changes (#562) * Revert "Remove replaceUndefinedByNull" This reverts commit 186544c. * Replace nulls for polar plot segment Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix date format expression check (#567) * Fix date format expression check * Apply format for date type with categorical date kind * Remove unused code Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Date axis fixes (#571) * Fix raw expression for data axis on updating * Assume null value equals to undefined on checking changes to reduce false alerts * Fix updating axis with log scale * Exclude negative values for Log scale * Keep current chart state on updating the dataset * Fix initialization of chart state * Check expression before updating plotsegment axis * Call UpdatePlotSegments action before save Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Set width for glyph in data axis (#573) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Add sky blue colors to Power BI color palette (#574) * Reset default color to match with ColorBrewer palette * Revert "Reset default color to match with ColorBrewer palette" This reverts commit 18dbe5f. * Add sky blue colors to Power BI Color palette * Fix color picker alignment in legend text color picker and scale editor Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Revert "Set width for glyph in data axis (#573)" (#579) This reverts commit eaefcc1. Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix launching nested chart editor (#588) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> * Fix nested chart state initialization (#590) Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: bongshin <bongshin@microsoft.com> Co-authored-by: Ilfat Galiev <v-igaliev@microsoft.com> Co-authored-by: Daniel Marsh-Patrick <daniel@coacervo.co> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.