Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import documents in parallel if > 1 #49

Closed
teresaqhoang opened this issue Jul 26, 2023 · 1 comment · Fixed by #83
Closed

Import documents in parallel if > 1 #49

teresaqhoang opened this issue Jul 26, 2023 · 1 comment · Fixed by #83
Assignees
@dehoward
Labels
enhancement New feature or request sk team issue webapi Pull requests that update .net code

Comments

@teresaqhoang
Copy link
Contributor

If multiple docs are uploaded, import in parallel
@teresaqhoang teresaqhoang added enhancement New feature or request webapi Pull requests that update .net code labels Jul 26, 2023
@dehoward dehoward mentioned this issue Aug 1, 2023
Merged
4 tasks
@dehoward dehoward assigned dehoward and unassigned TaoChenOSU Aug 3, 2023
@crickman
Copy link
Contributor

crickman commented Aug 3, 2023 •
edited
Loading

@dehoward FYI - If this work impacts DocumentImportController it will need to propagate to the new controller (for the semantic-memory service work) since we're bringing up the new components along-side the existing ones (as an execution strategy). I'm happy to translate any change into our workstream, but just wanted to raise awareness.

If this deeply impacts the API implementation w.r.t. document memory (which I suspect it doesn't), then perhaps we consider how to order?

github-merge-queue bot pushed a commit that referenced this issue Aug 7, 2023
@dehoward
Upload documents in parallel + truncate text for long document names (#…
03359da 
…83)

### Motivation and Context

<!-- Thank you for your contribution to the copilot-chat repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
resolves #49.

### Description 

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
- `DocumentImportController`: changed to use `Task.WhenAll` when
importing documents.
- all other files: changed to show overflow text on hover and to
truncate long document names (shown below).
<img width="184" alt="image"
src="https://github.com/microsoft/chat-copilot/assets/52973358/a000834d-ead1-4462-9f09-c54aaa392ceb">
<img width="391" alt="image"
src="https://github.com/microsoft/chat-copilot/assets/52973358/ae95f4c3-f9c2-4239-9cc9-ec4909087a44">
<img width="208" alt="image"
src="https://github.com/microsoft/chat-copilot/assets/52973358/80f01453-3a93-4982-b552-1a2d05fe900e">



### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehoward dehoward

Labels
enhancement New feature or request sk team issue webapi Pull requests that update .net code
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upload documents in parallel + truncate text for long document names dehoward/chat-copilot
5 participants
@TaoChenOSU @alliscode @dehoward @crickman @teresaqhoang