Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor webapi directory structure #100

Merged
merged 15 commits into from
Aug 8, 2023
Merged

Refactor webapi directory structure #100

merged 15 commits into from
Aug 8, 2023

Conversation

dehoward
Copy link
Contributor

@dehoward dehoward commented Aug 3, 2023 •
edited
Loading

Motivation and Context

as the project has grown, the structure of webapi has become a bit hard to parse through, especially for a new dev coming into the project. this PR aims to reduce that tension and in general, reduce the clutter within the api.

NOTE: the PR will be easier to review by going through each commit separately.

Description

  • moves deploy folder into scripts folder.
  • moves importdocument folder into tools folder.
  • moves code from webapi/CopilotChat up a level and removes duplicate folders.
  • changes root namespace from SemanticKernel.Service to CopilotChat.WebApi.

Contribution Checklist

@dehoward
condense folders (no code changes)
5920d29 
this commit moves any `*.cs` code living out of `webapi/CopilotChat`,
into the `webapi/CopilotChat` folder, along with the `.csproj` file.

other changes:
- moves `deploy` folder into `scripts` folder
- moves `importdocument` folder into `tools` folder
- deletes the `CopilotChat.sln` file living at the root level
@dehoward
merge ServiceExtensions + SemanticKernelExtensions
45c4135
@dehoward
remove 'SemanticKernel.Service' from namespace
3eca13f
@dehoward dehoward self-assigned this Aug 3, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation webapi Pull requests that update .net code PR: ready for review labels Aug 3, 2023
@github-actions github-actions bot added the github actions Pull requests that update GitHub Actions code label Aug 3, 2023
crickman
crickman previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@crickman crickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice structureal update. Love the shorter namespaces.

momuno
momuno reviewed Aug 3, 2023
View reviewed changes
scripts/deploy/main.json Outdated Show resolved Hide resolved
teresaqhoang
teresaqhoang requested changes Aug 3, 2023
View reviewed changes
webapi/CopilotChatWebApi.sln Outdated Show resolved Hide resolved
webapi/CopilotChat/Models/DocumentImportForm.cs Outdated Show resolved Hide resolved
glahaye
glahaye reviewed Aug 3, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
glahaye
glahaye reviewed Aug 3, 2023
View reviewed changes
webapi/appsettings.json Outdated Show resolved Hide resolved
glahaye

This comment was marked as outdated.

Sign in to view

glahaye
glahaye requested changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@glahaye glahaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove those credentials!

glahaye
glahaye reviewed Aug 3, 2023
View reviewed changes
webapi/appsettings.json Outdated Show resolved Hide resolved
momuno
momuno reviewed Aug 3, 2023
View reviewed changes
webapi/appsettings.json Outdated Show resolved Hide resolved
alliscode
alliscode requested changes Aug 4, 2023
View reviewed changes
CopilotChatWebApi.sln Outdated Show resolved Hide resolved
scripts/deploy/main.bicep Show resolved Hide resolved
webapi/CopilotChatWebApi.csproj Outdated Show resolved Hide resolved
anilgaddam0966
anilgaddam0966 reviewed Aug 4, 2023
View reviewed changes
Copy link

@anilgaddam0966 anilgaddam0966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

alliscode
alliscode previously approved these changes Aug 7, 2023
View reviewed changes
alliscode
alliscode previously approved these changes Aug 7, 2023
View reviewed changes
@dehoward dehoward enabled auto-merge August 7, 2023 18:30
@dehoward dehoward added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review labels Aug 7, 2023
glahaye
glahaye previously approved these changes Aug 7, 2023
View reviewed changes
@dehoward dehoward dismissed stale reviews from glahaye and alliscode via c6b04e3 August 7, 2023 21:33
@dehoward dehoward disabled auto-merge August 8, 2023 00:01
@dehoward dehoward added this pull request to the merge queue Aug 8, 2023
Merged via the queue into microsoft:main with commit b926544 Aug 8, 2023
8 checks passed
@dehoward dehoward deleted the refactor-webapi-structure branch August 8, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momuno momuno momuno left review comments

@961527 961527 961527 left review comments

@anilgaddam0966 anilgaddam0966 anilgaddam0966 left review comments

@alliscode alliscode alliscode approved these changes

@teresaqhoang teresaqhoang teresaqhoang approved these changes

@glahaye glahaye glahaye left review comments

@crickman crickman crickman left review comments

Assignees

@dehoward dehoward

Labels
documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code PR: ready to merge PR has been approved by all reviewers, and is ready to merge. webapi Pull requests that update .net code
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dehoward @glahaye @alliscode @momuno @crickman @teresaqhoang @961527 @anilgaddam0966