Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run formatting scripts during PR builds #124

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Conversation

dehoward
Copy link
Contributor

@dehoward dehoward commented Aug 8, 2023

Motivation and Context

brings in the renaming/consolidation changes from #60 and adds the format scripts to run as part of PR builds.
hopefully one day we will have automated fixing of the formatting errors, but for now they must be fixed by the developer manually.

Description

  • fixes all formatting errors.
  • updates READMEs to use relative links where possible since absolute links are not caught by markdown-link-check.
  • github workflows:
    • adds copilot-format-frontend which runs yarn format to check if formatting is correct.
    • renames node-pr to copilot-build-frontend and removes the find-yarn-projects job from the workflow.
    • removes copilot-chat-package in favor of copilot-build-backend since the two workflows seem identical.
      also changes copilot-build-backend to run dotnet format, and also run when PRs are created.

Contribution Checklist

@dehoward dehoward self-assigned this Aug 8, 2023
@github-actions github-actions bot added webapp Pull requests that update Typescript code PR: ready for review github actions Pull requests that update GitHub Actions code labels Aug 8, 2023
@dehoward
Copy link
Contributor Author

dehoward commented Aug 8, 2023

need to test dotnet format check

glahaye
glahaye previously approved these changes Aug 8, 2023
alliscode
alliscode previously approved these changes Aug 8, 2023
@dehoward dehoward dismissed stale reviews from alliscode and glahaye via 31f8ca4 August 8, 2023 18:35
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 8, 2023
@github-actions github-actions bot added the webapi Pull requests that update .net code label Aug 8, 2023
alliscode
alliscode previously approved these changes Aug 8, 2023
@dehoward dehoward enabled auto-merge August 8, 2023 20:13
@dehoward dehoward added this pull request to the merge queue Aug 8, 2023
@dehoward dehoward removed this pull request from the merge queue due to a manual request Aug 8, 2023
@dehoward dehoward added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 2913d1d Aug 8, 2023
7 checks passed
@dehoward dehoward deleted the add-format-workflows branch August 8, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code webapi Pull requests that update .net code webapp Pull requests that update Typescript code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants