Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Adding new app state to handle user info #145

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

teresaqhoang
Copy link
Contributor

@teresaqhoang teresaqhoang commented Aug 9, 2023

Motivation and Context

Added new app state for setting user info, refactored app views, and added shared styles for informative views.

This is a fix for a bug where the webapp would get stuck on the Loading Chats page. Something with SSO caused this.

Description

  • The App component now transitions to a SettingUserInfo state after successfully discovering the backend, and then to the LoadingChats state after successfully setting the active user info.
  • The user info status text in the App component has been updated to display a default message while fetching user information, and an error component has been added to display an error message at view level.
  • A new useSharedClasses hook has been added to provide a set of shared styles for informative views.
  • The BackendProbe component has also been updated to use the shared informativeView class.
  • Added tesseract data files to gitignore

Contribution Checklist

@teresaqhoang teresaqhoang requested review from TaoChenOSU, dehoward and a team August 9, 2023 21:44
@teresaqhoang teresaqhoang self-assigned this Aug 9, 2023
@github-actions github-actions bot added webapp Pull requests that update Typescript code PR: ready for review labels Aug 9, 2023
glahaye
glahaye previously approved these changes Aug 9, 2023
webapp/src/App.tsx Outdated Show resolved Hide resolved
TaoChenOSU
TaoChenOSU previously approved these changes Aug 10, 2023
dehoward
dehoward previously approved these changes Aug 10, 2023
@teresaqhoang teresaqhoang added this pull request to the merge queue Aug 11, 2023
Merged via the queue into microsoft:main with commit 83e0201 Aug 11, 2023
6 checks passed
@teresaqhoang teresaqhoang deleted the set-user-info-state branch August 11, 2023 16:00
@teresaqhoang teresaqhoang linked an issue Aug 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapp Pull requests that update Typescript code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Complete enhancement for chat copilot for customer demos
4 participants