Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql memory store #175

Merged

Conversation

kbeaugrand
Copy link
Contributor

@kbeaugrand kbeaugrand commented Aug 14, 2023

Motivation and Context

I would like to provide a production-grade PaaS solution to store the vector database.
It provides PostgreSQL database support for memory. We can now use Azure Database for PostgreSQL or CosmosDB for PostgreSQL.

Fixes #166

Description

I added configuration support for PostgreSQL. in the kernel initialization.
Furthermore I updated the deployment script to support this configuration.

Note: In the deployment scripts, I've added the SqlAdminPassword parameter, which must be supplied during provisioning. I intentionally named it without the PostgreSQL name, as I also worked on implementing SQL Server Memory store in the SK repository. This parameter could be used by both databases during deployment.

Contribution Checklist

Not found test project on the API part ;(

  • I didn't break anyone 馃槃

@github-actions github-actions bot added webapi Pull requests that update .net code deployment Issues related to deploying Chat-Copilot PR: ready for review labels Aug 14, 2023
@kbeaugrand kbeaugrand force-pushed the feature/add-postgresql-memory-store branch from 58550e3 to eae6062 Compare August 14, 2023 14:23
@crickman crickman added enhancement New feature or request external dependency issue Issues related to external dependencies (e.g. Azure) labels Aug 14, 2023
kbeaugrand and others added 2 commits August 15, 2023 10:39
Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
@kbeaugrand
Copy link
Contributor Author

@glahaye thank you for the review, I apply fixes from your suggestions and comments.

Copy link
Collaborator

@glahaye glahaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crickman crickman added this pull request to the merge queue Aug 15, 2023
Merged via the queue into microsoft:main with commit 07075ae Aug 15, 2023
6 checks passed
@kbeaugrand kbeaugrand deleted the feature/add-postgresql-memory-store branch August 15, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues related to deploying Chat-Copilot enhancement New feature or request external dependency issue Issues related to external dependencies (e.g. Azure) webapi Pull requests that update .net code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Use PostgresSQL as MemoryStore
3 participants