-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Chat #193
Merged
Merged
Delete Chat #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliscode
requested changes
Aug 16, 2023
alliscode
previously requested changes
Aug 16, 2023
glahaye
reviewed
Aug 16, 2023
alliscode
reviewed
Aug 18, 2023
TaoChenOSU
reviewed
Aug 18, 2023
gitri-ms
reviewed
Aug 21, 2023
gitri-ms
requested changes
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
reviewed
Aug 21, 2023
glahaye
previously approved these changes
Aug 21, 2023
TaoChenOSU
approved these changes
Aug 22, 2023
gitri-ms
approved these changes
Aug 22, 2023
Discussed offline and got sign-off after I addressed his last comments. Ben's oof now for the week, don't want to block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
webapi
Pull requests that update .net code
webapp
Pull requests that update Typescript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR enables chat deletion. For V1, any user is able to delete any chat they're a part of. This will delete the chat for all participants, including Chat Copilot, as well as all related resources (memories, messages, etc.).
Description
When a chat is deleted,
Contribution Checklist
- [ ] All unit tests pass, and I have added new tests where possible