Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scenario test readme #272

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add scenario test readme #272

merged 1 commit into from
Aug 30, 2023

Conversation

TaoChenOSU
Copy link
Collaborator

@TaoChenOSU TaoChenOSU commented Aug 29, 2023 •
edited
Loading

Motivation and Context

We fix the scenario tests. It' time to document how to run the tests locally.

Description

  1. Create a README with setup instructions to run the tests locally.
  2. Add a timeout of 30 seconds for each test.
  3. Rename some secrets so that they make more sense.

Contribution Checklist

@TaoChenOSU TaoChenOSU added documentation Improvements or additions to documentation enhancement New feature or request PR: ready for review labels Aug 29, 2023
@TaoChenOSU TaoChenOSU self-assigned this Aug 29, 2023
@github-actions github-actions bot added webapp Pull requests that update Typescript code github actions Pull requests that update GitHub Actions code labels Aug 29, 2023
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Aug 30, 2023
Merged via the queue into microsoft:main with commit 6cc615a Aug 30, 2023
6 checks passed
@TaoChenOSU TaoChenOSU deleted the users/taochen/scenario-test-readme branch August 30, 2023 15:36
@TaoChenOSU TaoChenOSU mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glahaye glahaye glahaye approved these changes

@alliscode alliscode alliscode approved these changes

@dehoward dehoward Awaiting requested review from dehoward

Assignees

@TaoChenOSU TaoChenOSU

Labels
documentation Improvements or additions to documentation enhancement New feature or request github actions Pull requests that update GitHub Actions code webapp Pull requests that update Typescript code
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TaoChenOSU @glahaye @alliscode