Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SK from 0.19.230804.2-preview to 0.21.230828.2-preview #305

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Update SK from 0.19.230804.2-preview to 0.21.230828.2-preview #305

merged 3 commits into from
Sep 6, 2023

Conversation

TaoChenOSU
Copy link
Collaborator

Motivation and Context

Update SK from 0.19.230804.2-preview to 0.21.230828.2-preview

Description

The following changes have been made because of this update:

  1. Move away from using the logger (deprecated/removed) in SKcontext. Instead, it's going to use the logger that's passed in to the ChatSkill.
  2. Planner will always retry regardless of the error type (when is configured) as a result of the removal of PlanningException and KernelException along with the error codes.

Contribution Checklist

@TaoChenOSU TaoChenOSU added enhancement New feature or request webapi Pull requests that update .net code PR: ready for review labels Sep 6, 2023
@TaoChenOSU TaoChenOSU self-assigned this Sep 6, 2023
alliscode
alliscode previously approved these changes Sep 6, 2023
View reviewed changes
dehoward
dehoward requested changes Sep 6, 2023
View reviewed changes
webapi/Options/PlannerOptions.cs Outdated Show resolved Hide resolved
crickman
crickman previously approved these changes Sep 6, 2023
View reviewed changes
teresaqhoang
teresaqhoang reviewed Sep 6, 2023
View reviewed changes
webapi/Options/PlannerOptions.cs Outdated Show resolved Hide resolved
webapi/Options/PlannerOptions.cs Outdated Show resolved Hide resolved
@TaoChenOSU TaoChenOSU force-pushed the users/taochen/update_sk_version_to_0.21.230828.2-preview branch from 60ed389 to dc54284 Compare September 6, 2023 20:23
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Sep 6, 2023
Merged via the queue into microsoft:main with commit fa7b8d2 Sep 6, 2023
7 checks passed
@TaoChenOSU TaoChenOSU deleted the users/taochen/update_sk_version_to_0.21.230828.2-preview branch September 6, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alliscode alliscode alliscode approved these changes

@dehoward dehoward dehoward approved these changes

@crickman crickman crickman approved these changes

@glahaye glahaye Awaiting requested review from glahaye

@teresaqhoang teresaqhoang Awaiting requested review from teresaqhoang

Assignees

@TaoChenOSU TaoChenOSU

Labels
enhancement New feature or request webapi Pull requests that update .net code
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TaoChenOSU @glahaye @alliscode @dehoward @crickman @teresaqhoang