Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async signature #334

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix async signature #334

merged 2 commits into from
Sep 12, 2023

Conversation

crickman
Copy link
Contributor

Motivation and Context

Incorrect controller route/method signature causing build error

Description

D:\a\chat-copilot\chat-copilot\webapi\Controllers\MaintenanceController.cs(50,55): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [D:\a\chat-copilot\chat-copilot\webapi\CopilotChatWebApi.csproj]

Contribution Checklist

@crickman crickman added bug Something isn't working PR: ready for review .NET Pull requests that update .net code labels Sep 12, 2023
@crickman crickman self-assigned this Sep 12, 2023
@github-actions github-actions bot added the webapi Pull requests that update .net code label Sep 12, 2023
teresaqhoang
teresaqhoang previously approved these changes Sep 12, 2023
@crickman crickman added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit b1beca8 Sep 12, 2023
7 checks passed
@crickman crickman deleted the fix_builderror_maintenance branch September 12, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working .NET Pull requests that update .net code webapi Pull requests that update .net code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants