-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ChatSkill to use new Chat Completions prompt format #337
Merged
teresaqhoang
merged 11 commits into
microsoft:main
from
teresaqhoang:Refactor-chat-message-completion-types
Sep 18, 2023
Merged
Refactor ChatSkill to use new Chat Completions prompt format #337
teresaqhoang
merged 11 commits into
microsoft:main
from
teresaqhoang:Refactor-chat-message-completion-types
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and AuthorRoles (system, assistant, user)
dehoward
reviewed
Sep 13, 2023
TaoChenOSU
reviewed
Sep 13, 2023
glahaye
reviewed
Sep 13, 2023
glahaye
reviewed
Sep 13, 2023
…lways including last user message in chat history
…lways including last user message in chat history
TaoChenOSU
reviewed
Sep 15, 2023
dehoward
reviewed
Sep 18, 2023
TaoChenOSU
approved these changes
Sep 18, 2023
dehoward
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
webapi
Pull requests that update .net code
webapp
Pull requests that update Typescript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR refactors the ChatSkill to use the new ChatCompletions prompt format as the meta-prompt template. The new format serves the prompt template as a series of context messages, where each message can be tagged a role, to prime the model in a certain way. These roles include: System, User, and Assistant.
Description
For ChatSkill, the prompt template for the meta-bot response request utilizes the message roles in the following way:
The series of messages between the user and the assistant is included both as few shot examples and additional context (chat history). The last user message is always included.
Other changes:
Contribution Checklist
- [ ] All unit tests pass, and I have added new tests where possible